Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unruly: BidVideo.Duration Support #3643

Merged
merged 1 commit into from
May 2, 2024
Merged

Unruly: BidVideo.Duration Support #3643

merged 1 commit into from
May 2, 2024

Conversation

bhainesnexxen
Copy link
Contributor

Builds the BidVideo.Duration object if video.dur is present.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5a324b3

unruly

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:27:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:53:	preProcess		72.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:93:	MakeBids		95.2%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:142:	getMediaTypeForImp	92.9%
total:									(statements)		85.3%

@Sonali-More-Xandr Sonali-More-Xandr merged commit cee7a57 into prebid:master May 2, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request May 2, 2024
Closed
mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024
@bhainesnexxen @mefjush
Unruly: bid.dur support (prebid#3643)
0e04c58 
Co-authored-by: Brian Haines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhainesnexxen @gargcreation1992 @Sonali-More-Xandr